Order schedules in select all #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The schedule promises coroutine queries all promises where next_run_time is less than or equal to tick time, we need to ensure that these schedules come back in a deterministic order.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
=======================================
Coverage 64.85% 64.85%
=======================================
Files 83 83
Lines 8829 8829
=======================================
Hits 5726 5726
Misses 2709 2709
Partials 394 394 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #192
Closes #194
Closes #195
Closes #196
Closes #197
Closes #198
Closes #199
Closes #201
The schedule promises coroutine queries all promises where next_run_time is less than or equal to tick time, we need to ensure that these schedules come back in a deterministic order.